Atte149/book-reader
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: force disk fallback in LocatorConverter to fix MD/TXT reading position (#40)

Browse source 
Background pre-processing for single-file imports (MD/TXT) was generating empty DB cache entries because it only looked at RAM content. This caused position saves in Vertical Mode to fail. This fix ensures that an empty cache entry triggers a disk-read fallback to generate valid semantic blocks on-demand.
This commit is contained in:
Aryan 2026-03-07 22:34:08 +05:30 • committed by GitHub
parent b9f8825ad7
commit 6bc4f9bafd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 104 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

11
app/src/main/java/com/aryan/reader/epubreader/EpubReaderScreen.kt
View file

@ -2161,9 +2161,10 @@ fun EpubReaderHost(
showDictionaryUpsellDialog = true
},
onCfiGenerated = { cfi ->
Timber.tag("PosSaveDiag").d("EpubReaderScreen: onCfiGenerated callback triggered with CFI: '$cfi'")
if (cfi.isBlank() || !cfi.startsWith('/')) {
Timber.w("onCfiGenerated received an invalid CFI, aborting save: '$cfi'"
)
Timber.tag("PosSaveDiag").w("EpubReaderScreen: onCfiGenerated received an invalid CFI, aborting save: '$cfi'")
if (isSavingAndExiting) {
isSavingAndExiting = false
onNavigateBack()
@ -2172,6 +2173,7 @@ fun EpubReaderHost(
}
scope.launch {
Timber.tag("PosSaveDiag").d("EpubReaderScreen: Requesting locator conversion for chapter $latestChapterIndex")
val locator =
locatorConverter.getLocatorFromCfi(
epubBook,
@ -2179,10 +2181,11 @@ fun EpubReaderHost(
cfi
)
Timber.tag("PosSaveDiag").d("EpubReaderScreen: Locator conversion returned: $locator")
if (locator != null) {
lastKnownLocator = locator
// Calculate progress (Logic moved out of `val progress` block for scope visibility)
val progressWithinChapter =
if (currentScrollHeightValue > currentClientHeightValue) {
val scrollableHeight =
@ -2945,7 +2948,7 @@ fun EpubReaderHost(
} else {
scope.launch {
lastKnownLocator?.let { locator ->
val cfi = locatorConverter.getCfiFromLocator(epubBook.title, locator)
val cfi = locatorConverter.getCfiFromLocator(epubBook, locator)
if (cfi != null) {
val targetChunk = locator.blockIndex / 20
chunkTargetOverride = targetChunk