Atte149/book-reader
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Bug fixes (#319)

Browse source 
* Fix TTS speaker persistence

* optimized redundant WebView updates

* Bumped version to 1.0.48
This commit is contained in:
Aryan 2026-05-16 22:59:53 +05:30 • committed by GitHub
parent 70c272baa7
commit bcf34af719
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 781 additions and 173 deletions
Download patch file Download diff file Expand all files Collapse all files

58
app/src/test/java/com/aryan/reader/pdf/PdfReaderCoreLogicTest.kt
View file

@ -6,6 +6,7 @@ import android.graphics.Rect
import androidx.compose.ui.graphics.Color
import com.aryan.reader.pdf.data.PdfAnnotation
import com.aryan.reader.pdf.data.PdfAnnotationRepository
import com.aryan.reader.pdf.data.PdfTextBox
import com.aryan.reader.pdf.data.VirtualPage
import com.aryan.reader.pdf.ocr.OcrBlock
import com.aryan.reader.pdf.ocr.OcrElement
@ -13,6 +14,7 @@ import com.aryan.reader.pdf.ocr.OcrLine
import com.aryan.reader.pdf.ocr.OcrResult
import kotlinx.coroutines.test.runTest
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Test
@ -107,6 +109,62 @@ class PdfReaderCoreLogicTest {
assertTrue(filename, filename.matches(Regex("Document_\\d{4}\\.pdf")))
}
@Test
fun `pdf export choice is hidden when loaded sidecars have no annotations`() {
assertFalse(
shouldShowPdfAnnotationExportChoice(
sidecarsReady = true,
annotations = mapOf(0 to emptyList()),
textBoxes = emptyList(),
highlights = emptyList()
)
)
}
@Test
fun `pdf export choice is shown when exportable annotations exist`() {
val inkAnnotation = PdfAnnotation(
type = AnnotationType.INK,
inkType = InkType.PEN,
pageIndex = 0,
points = listOf(PdfPoint(0.1f, 0.2f)),
color = Color.Black,
strokeWidth = 0.01f
)
val textBox = PdfTextBox(
id = "box",
pageIndex = 0,
relativeBounds = androidx.compose.ui.geometry.Rect(0.1f, 0.1f, 0.4f, 0.2f),
text = "note",
color = Color.Black,
backgroundColor = Color.Transparent,
fontSize = 16f
)
val highlight = PdfUserHighlight(
pageIndex = 0,
bounds = listOf(RectF(0.1f, 0.1f, 0.4f, 0.2f)),
color = PdfHighlightColor.YELLOW,
text = "selected",
range = 0 to 8
)
assertTrue(shouldShowPdfAnnotationExportChoice(true, mapOf(0 to listOf(inkAnnotation)), emptyList(), emptyList()))
assertTrue(shouldShowPdfAnnotationExportChoice(true, emptyMap(), listOf(textBox), emptyList()))
assertTrue(shouldShowPdfAnnotationExportChoice(true, emptyMap(), emptyList(), listOf(highlight)))
}
@Test
fun `pdf export choice remains available until sidecars are loaded`() {
assertTrue(
shouldShowPdfAnnotationExportChoice(
sidecarsReady = false,
annotations = emptyMap(),
textBoxes = emptyList(),
highlights = emptyList()
)
)
}
@Test
fun `pdfRenderPageId separates same page across documents`() {
val firstDocumentPage = pdfRenderPageId("book-a", 0, VirtualPage.PdfPage(0))

41
app/src/test/java/com/aryan/reader/tts/TtsSpeakerPreferencesTest.kt Normal file
View file

@ -0,0 +1,41 @@
package com.aryan.reader.tts
import android.content.Context
import org.junit.Assert.assertEquals
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment
@RunWith(RobolectricTestRunner::class)
class TtsSpeakerPreferencesTest {
private lateinit var context: Context
@Before
fun setUp() {
context = RuntimeEnvironment.getApplication()
context.getSharedPreferences(TTS_SETTINGS_PREFS_NAME, Context.MODE_PRIVATE)
.edit()
.clear()
.commit()
}
@Test
fun `tts speaker preference saves and loads selected ai voice`() {
saveTtsSpeaker(context, "Kore")
assertEquals("Kore", loadTtsSpeaker(context))
}
@Test
fun `tts speaker preference falls back to default for blank or unknown voices`() {
assertEquals(DEFAULT_SPEAKER_ID, loadTtsSpeaker(context))
saveTtsSpeaker(context, "")
assertEquals(DEFAULT_SPEAKER_ID, loadTtsSpeaker(context))
saveTtsSpeaker(context, "MissingVoice")
assertEquals(DEFAULT_SPEAKER_ID, loadTtsSpeaker(context))
}
}