book-reader/app/src/test/java/com/aryan/reader/epubreader/EpubReaderBridgeAndControlsTest.kt
Aryan 83dcafa4b6
Windows ga (#358)
* Enhance Cloud TTS with navigation controls and shared UI overlay in desktop app

* Refactor Cloud TTS voice settings and remove standalone settings overlay on desktop app

* Persist reader window state and improve slider interaction in desktop app

* Improve PDF page transitions and refine focus management in desktop app

* Refactor scrollbar interaction and adjust desktop modal focus handling

* Improve PDF sidecar synchronization and cross-platform metadata compatibility

* Refactor PDF annotation comment logic to shared module and implement Desktop UI

* Refactor reader screen to use tap-to-toggle and full-width styling in desktop app

* Refactor reader workspace layout and chrome-panel interactions

* Implement global search keyboard shortcuts and focusable chrome layers

* Implement flavor-specific legal links and update the About UI

* Refactor reader UI controls on desktop app

* Enhance desktop folder sync with background metadata extraction and improved error handling

* Refactor Library UI and remove redundant Home tab in desktop app

* Add custom tooltips to reader icon buttons in desktop app

* Integrate app theme controls into reader interfaces on desktop

* Add right-to-left pagination support and improve focus restoration on desktop app

* Improve EPUB pagination geometry and diagnostic logging for layout cutoffs on desktop app

* Update desktop reader defaults and implement settings migration

* Implement block-based position tracking in ReaderLocator

* Enhance EPUB highlighting reliability in desktop app

* Add support for custom reader themes and update highlight palette logic in desktop app

* Replace the Tools panel with a "More" dropdown menu and refactor account UI

* Implement account profile header in desktop sidebar

* Implement cloud sync reliability improvements and sidebar toggle on desktop app

* Improve EPUB annotation synchronization and highlight mapping accuracy in desktop app

* Integrate WebView2 for EPUB vertical rendering on Windows

* Refactor reader layout logic and enhance WebView2 diagnostics

* Improve vertical reading layout and WebView2 resizing on Desktop

* Refine vertical reading mode layout and margin handling

* Enhance reader locator precision and Desktop mode-switching reliability

* Implement chapter-level caching and warm-start pagination in desktop app

* Replace bundled KCEF with native system webviews via SWT

* Refactor EPUB page info bar visibility and layout logic

* Improve PDF toolbar persistence and fix tab reactivation logic

* Enable multi-selection and bulk operations for custom fonts

* Refactor instrumentation tests

* Add EPUB UI test fixture and initial instrumentation tests

* Expand EpubReader UI tests and improve accessibility

* Add instrumentation tests and test tags for library and reader screens

* Enhance OPDS parser logic and catalog integration

* Add support for toggling local synchronization on a per-folder basis.

* Implement tri-state sizing for the TTS overlay

* Persist TTS overlay size across sessions

* Refactor reader brightness control and add incremental step buttons

* Improve CSS support, pagination control, and style-aware semantic caching

* Improve link handling, interaction, and diagnostics in the paginated reader

* crash fixes

* Implement persistent pending removal for external files

* Implement book-specific word replacements

* Add native vertical reading mode with custom renderer

* Implement text selection and navigation improvements for the native vertical reader

* Implement locator-based navigation and improved vertical scrolling in native vertical mode in epub

* Implement lazy loading and chapter prefetching for native vertical reader

* Improve window lifecycle and disposal handling on Desktop

* Optimize vertical reading performance in desktop app

* Enhance TTS start accuracy and diagnostic logging on desktop

* Refactor AI settings visibility on desktop

* Improve pagination height measurement and enhance cutoff diagnostics

* Implement lifecycle management and improve justified text splitting for pagination

* Refine AI usage tracking and force AI feature visibility on Desktop

* Add descriptive context comments and usage examples to string and plural resources.

* Optimize performance and memory usage in search and state mapping

* Replace reader page sliders with minimal slider and navigation controls

* Add support for CBT comic archives

* Harden file path validation and XML parsing to prevent security vulnerabilities

* Implement local account profile caching and optimize desktop performance

* Improve desktop persistence reliability and add Linux secure storage support

* Improved PDF zoom stability and layout prediction during zoom commits

* Improved PDF spread layout prediction, reader focus restoration, and account profile caching

* Enhance highlight precision and scoping using block-local offsets and CFIs

* Enhance cloud book content synchronization and background downloads

* Implement granular timestamp tracking for reading positions and PDF annotations

* Restrict diagnostic logging and stack traces to debug builds

* Refine PDF page gaps and reader chrome interaction logic

* Refactor PDF highlight rendering and overhaul Desktop sidebar UI

* Implement a new interaction dock and undo/redo history for PDF annotations in desktop

* Enhance PDF color picker and improve navigation scroll restoration

* Add highlight palette customization and improve selection menu UI in desktop app epub reader

* Enhance desktop shelf management and library organization
2026-06-02 00:51:42 +05:30

317 lines
12 KiB
Kotlin

package com.aryan.reader.epubreader
import android.webkit.WebView
import com.aryan.reader.RenderMode
import io.mockk.mockk
import io.mockk.verify
import kotlinx.coroutines.CompletableDeferred
import kotlinx.coroutines.test.runTest
import org.json.JSONArray
import org.json.JSONObject
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
@RunWith(RobolectricTestRunner::class)
class EpubReaderBridgeAndControlsTest {
@Test
fun `sanitizePlaceholders keeps one header per toolbar section and inserts empty placeholders`() {
val input = listOf(
FlatToolItem("old_header", FlatItemType.SECTION_HEADER, section = ToolbarSection.BOTTOM),
FlatToolItem("format", FlatItemType.TOOL, tool = ReaderTool.FORMAT, section = ToolbarSection.BOTTOM),
FlatToolItem("more_header", FlatItemType.MORE_HEADER, title = "More"),
FlatToolItem("reading_mode", FlatItemType.MORE_TOOL, tool = ReaderTool.READING_MODE)
)
val sanitized = sanitizePlaceholders(input)
assertEquals(
listOf(
FlatItemType.SECTION_HEADER,
FlatItemType.EMPTY_PLACEHOLDER,
FlatItemType.SECTION_HEADER,
FlatItemType.TOOL,
FlatItemType.SECTION_HEADER,
FlatItemType.EMPTY_PLACEHOLDER,
FlatItemType.MORE_HEADER,
FlatItemType.MORE_TOOL
),
sanitized.map { it.type }
)
assertEquals(listOf(ToolbarSection.TOP, ToolbarSection.BOTTOM, ToolbarSection.HIDDEN), sanitized.filter { it.type == FlatItemType.SECTION_HEADER }.map { it.section })
assertEquals(ReaderTool.FORMAT, sanitized.single { it.type == FlatItemType.TOOL }.tool)
}
@Test
fun `auto scroll bridge invokes chapter end callback`() {
var calls = 0
AutoScrollJsBridge { calls++ }.onChapterEnd()
assertEquals(1, calls)
}
@Test
fun `tts bridge relays nonblank structured text and normalizes blank payloads`() = runTest {
val received = CompletableDeferred<String>()
val bridge = TtsJsBridge(scope = this, ttsStructuredTextHandler = { received.complete(it) })
bridge.onStructuredTextExtracted("[{\"text\":\"Hello\"}]")
assertEquals("[{\"text\":\"Hello\"}]", received.await())
val blankReceived = CompletableDeferred<String>()
TtsJsBridge(scope = this, ttsStructuredTextHandler = { blankReceived.complete(it) }).onStructuredTextExtracted(" ")
assertEquals("[]", blankReceived.await())
}
@Test
fun `highlight bridge forwards create and click events`() {
var created: Triple<String, String, String>? = null
var clicked: List<Any>? = null
val bridge = HighlightJsBridge(
onCreateCallback = { cfi, text, color -> created = Triple(cfi, text, color) },
onClickCallback = { cfi, text, left, top, right, bottom ->
clicked = listOf(cfi, text, left, top, right, bottom)
}
)
bridge.onHighlightCreated("/4", "Text", "yellow")
bridge.onHighlightClicked("/4", "Text", 1, 2, 3, 4)
assertEquals(Triple("/4", "Text", "yellow"), created)
assertEquals(listOf("/4", "Text", 1, 2, 3, 4), clicked)
}
@Test
fun `content snippet progress footnote and ai bridges forward callbacks`() = runTest {
var requestedChunk = -1
var snippet = "" to ""
var progressCalls = 0
var lastChunk = -1
var footnote = ""
val aiContent = CompletableDeferred<String>()
ContentBridge { requestedChunk = it }.requestChunk(7)
SnippetJsBridge { cfi, text -> snippet = cfi to text }.onSnippetExtracted("/6", "Snippet")
val progress = ProgressJsBridge {
progressCalls++
lastChunk = it
}
progress.updateTopChunk(2)
progress.updateTopChunk(2)
progress.updateTopChunk(3)
FootnoteJsBridge { footnote = it }.onFootnoteRequested("<p>Note</p>")
AiJsBridge(scope = this, onContentReady = { aiContent.complete(it) }).onContentExtractedForSummarization("Chapter text")
assertEquals(7, requestedChunk)
assertEquals("/6" to "Snippet", snippet)
assertEquals(2, progressCalls)
assertEquals(3, lastChunk)
assertEquals("<p>Note</p>", footnote)
assertEquals("Chapter text", aiContent.await())
}
@Test
fun `ai bridge ignores blank content`() = runTest {
var called = false
AiJsBridge(scope = this, onContentReady = { called = true }).onContentExtractedForSummarization(" ")
assertFalse(called)
}
@Test
fun `cfi bridge parses save bookmark and scroll callbacks with fallback for invalid save json`() {
val saved = mutableListOf<String>()
val bookmark = mutableListOf<String>()
val scrollResults = mutableListOf<Boolean>()
val bridge = CfiJsBridge(
onCfiReady = { saved.add(it) },
onCfiForBookmarkReady = { bookmark.add(it) },
onScrollFinishedCallback = { scrollResults.add(it) }
)
bridge.onCfiExtracted(JSONObject().put("cfi", "/4/2:8").put("log", JSONArray()).toString())
bridge.onCfiExtracted(JSONObject().put("cfi", "").toString())
bridge.onCfiExtracted("broken")
bridge.onCfiForBookmarkExtracted(JSONObject().put("cfi", "/6/4:1").toString())
bridge.onCfiForBookmarkExtracted("broken")
bridge.onScrollFinished(true)
bridge.onScrollFinished(false)
assertEquals(listOf("/4/2:8", "/4"), saved)
assertEquals(listOf("/6/4:1"), bookmark)
assertEquals(listOf(true, false), scrollResults)
}
@Test
fun `cfi bridge preserves full reading position cfi payloads for save and bookmark callbacks`() {
val saved = mutableListOf<String>()
val bookmark = mutableListOf<String>()
val bridge = CfiJsBridge(
onCfiReady = { saved.add(it) },
onCfiForBookmarkReady = { bookmark.add(it) },
onScrollFinishedCallback = {}
)
val cfi = "/6/4[chapter]!/4/2/8:137"
bridge.onCfiExtracted(JSONObject().put("cfi", cfi).put("log", JSONArray().put("exact")).toString())
bridge.onCfiForBookmarkExtracted(JSONObject().put("cfi", cfi).put("log", JSONArray()).toString())
assertEquals(listOf(cfi), saved)
assertEquals(listOf(cfi), bookmark)
}
@Test
fun `updateAutoScrollJs emits start and stop commands`() {
val webView = mockk<WebView>(relaxed = true)
updateAutoScrollJs(webView, playing = true, speed = 1.25f)
updateAutoScrollJs(webView, playing = false, speed = 9f)
verify { webView.evaluateJavascript("javascript:window.autoScroll.start(1.25);", null) }
verify { webView.evaluateJavascript("javascript:window.autoScroll.stop();", null) }
}
@Test
fun `web view hit test guard treats chromium null state as unknown tap`() {
val type = readWebViewHitTestTypeOrNull {
throw NullPointerException("chromium hit test result missing")
}
assertNull(type)
assertFalse(isWebViewAnchorHitTestType(type))
}
@Test
fun `web view hit test helper detects anchor result types`() {
assertTrue(isWebViewAnchorHitTestType(WebView.HitTestResult.SRC_ANCHOR_TYPE))
assertTrue(isWebViewAnchorHitTestType(WebView.HitTestResult.SRC_IMAGE_ANCHOR_TYPE))
assertFalse(isWebViewAnchorHitTestType(null))
assertFalse(isWebViewAnchorHitTestType(WebView.HitTestResult.IMAGE_TYPE))
}
@Test
fun `initiateTtsPlayback chooses web extraction for vertical mode and callback for paginated mode`() {
val webView = mockk<WebView>(relaxed = true)
var paginatedStarts = 0
initiateTtsPlayback(RenderMode.VERTICAL_SCROLL, webView) { paginatedStarts++ }
initiateTtsPlayback(RenderMode.PAGINATED, webView) { paginatedStarts++ }
verify { webView.evaluateJavascript("javascript:TtsBridgeHelper.extractAndRelayText();", null) }
assertEquals(1, paginatedStarts)
}
@Test
fun `reader tool metadata has stable unique names and categories`() {
assertEquals(ReaderTool.entries.size, ReaderTool.entries.map { it.name }.toSet().size)
assertTrue(ReaderTool.entries.any { it.category == "Top Bar" })
assertTrue(ReaderTool.entries.any { it.category == "Bottom Bar" })
assertTrue(ReaderTool.entries.any { it.category == "Overflow Menu" })
assertEquals("Top Bar", ReaderTool.SCREEN_ORIENTATION.category)
assertEquals("Top Bar", ReaderTool.BRIGHTNESS.category)
}
@Test
fun `reader toolbar reset defaults match first-run toolbar defaults`() {
assertEquals(
setOf(ReaderTool.SCREEN_ORIENTATION.name, ReaderTool.BRIGHTNESS.name),
defaultReaderHiddenTools()
)
assertEquals(ReaderTool.entries.toList(), defaultReaderToolOrder())
assertEquals(
ReaderTool.entries.filter { it.category == "Bottom Bar" }.map { it.name }.toSet(),
defaultReaderBottomTools()
)
val defaultItems = buildReaderToolbarItems(
hiddenTools = defaultReaderHiddenTools(),
toolOrder = defaultReaderToolOrder(),
bottomTools = defaultReaderBottomTools()
)
assertEquals(
ToolbarSection.HIDDEN,
defaultItems.single { it.tool == ReaderTool.SCREEN_ORIENTATION }.section
)
assertEquals(
ToolbarSection.HIDDEN,
defaultItems.single { it.tool == ReaderTool.BRIGHTNESS }.section
)
assertEquals(
ToolbarSection.BOTTOM,
defaultItems.single { it.tool == ReaderTool.SLIDER }.section
)
assertTrue(defaultItems.any { it.type == FlatItemType.MORE_TOOL && it.tool == ReaderTool.FILE_INFO })
}
@Test
fun `epub overflow sections end at auto scroll when tts submenu and file info are hidden`() {
val sections = epubOverflowMenuSections(
hiddenTools = setOf(
ReaderTool.TTS_SETTINGS.name,
ReaderTool.TTS_REPLACEMENTS.name,
ReaderTool.BOOK_REPLACEMENTS.name
),
hasHiddenToolbarTools = false,
hasToggleReflow = false,
hasDeleteReflow = false,
hasFileInfo = false
)
assertEquals(EpubOverflowMenuSection.AUTO_SCROLL, sections.last())
assertTrue(EpubOverflowMenuSection.TTS_SETTINGS !in sections)
assertTrue(EpubOverflowMenuSection.BOOK_REPLACEMENTS !in sections)
}
@Test
fun `epub overflow sections expose book replacements when visible`() {
val sections = epubOverflowMenuSections(
hiddenTools = emptySet(),
hasHiddenToolbarTools = false,
hasToggleReflow = false,
hasDeleteReflow = false,
hasFileInfo = false
)
assertTrue(EpubOverflowMenuSection.BOOK_REPLACEMENTS in sections)
assertTrue(sections.indexOf(EpubOverflowMenuSection.BOOK_REPLACEMENTS) < sections.indexOf(EpubOverflowMenuSection.TTS_SETTINGS))
}
@Test
fun `epub overflow sections expose file info only when available and visible`() {
val visibleSections = epubOverflowMenuSections(
hiddenTools = emptySet(),
hasHiddenToolbarTools = false,
hasToggleReflow = false,
hasDeleteReflow = false,
hasFileInfo = true
)
val missingItemSections = epubOverflowMenuSections(
hiddenTools = emptySet(),
hasHiddenToolbarTools = false,
hasToggleReflow = false,
hasDeleteReflow = false,
hasFileInfo = false
)
val hiddenSections = epubOverflowMenuSections(
hiddenTools = setOf(ReaderTool.FILE_INFO.name),
hasHiddenToolbarTools = false,
hasToggleReflow = false,
hasDeleteReflow = false,
hasFileInfo = true
)
assertTrue(EpubOverflowMenuSection.FILE_INFO in visibleSections)
assertEquals(EpubOverflowMenuSection.FILE_INFO, visibleSections.last())
assertFalse(EpubOverflowMenuSection.FILE_INFO in missingItemSections)
assertFalse(EpubOverflowMenuSection.FILE_INFO in hiddenSections)
}
}