From fb7b696b140c811f247c410532fa3d582b27b0cc Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Sun, 11 Aug 2024 17:48:06 +0300 Subject: [PATCH 01/10] Update README.md (Removed outdated screenshots) --- assets/README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/assets/README.md b/assets/README.md index ce65b2cf..023a9d1a 100644 --- a/assets/README.md +++ b/assets/README.md @@ -11,7 +11,5 @@ - -
From 73777274a4fa8c000dee455115a0c1d35aea1467 Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Sun, 11 Aug 2024 19:13:03 +0300 Subject: [PATCH 02/10] Update README.md (Removed gif) --- README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index 031a14e1..f066fbb7 100644 --- a/README.md +++ b/README.md @@ -35,9 +35,8 @@ Built using Jetpack Compose and Kotlin. -## 🖌️ Screenshots + GIF +## 🖌️ Screenshots -
From e4b884e150c302447f25dc9d67dded4762b50385 Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Mon, 12 Aug 2024 23:28:43 +0300 Subject: [PATCH 03/10] =?UTF-8?q?=F0=9F=9A=80=20Add=20issue=20templates?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Added issue templates for users to use when submitting errors. This will ensure consistency of Issues and solving issues more quickly due to more clear description. --- .github/ISSUE_TEMPLATE/book-parser-issue.md | 26 +++++++++++++++ .github/ISSUE_TEMPLATE/bug_report.md | 35 +++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature-request.md | 23 ++++++++++++++ 3 files changed, 84 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/book-parser-issue.md create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature-request.md diff --git a/.github/ISSUE_TEMPLATE/book-parser-issue.md b/.github/ISSUE_TEMPLATE/book-parser-issue.md new file mode 100644 index 00000000..37082a73 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/book-parser-issue.md @@ -0,0 +1,26 @@ +--- +name: Book parser issue +about: Report an issue with parser +title: '' +labels: "\U0001F3BC Parser issue" +assignees: Acclorite + +--- + +**Where it happened?** +Describe where issue with the parser occurred, for example: "Issue occurred at 40.1%" or "Could not add this book because of error in Browse Screen". + +**Short description of what is wrong** +Describe in short the problem, for example: "Weird line break" or "App says file is empty when it is not". + +**Attach problematic file (necessary!)** +Attach the file you had problems with. This step is necessary, without it issue may be closed, if no appropriate reason given. + +**Screenshots (optional)** +If applicable, add screenshots to help explain your problem. + +**Additional context (optional)** +Any additional info you may want to give. + +Please don't use titles like [Parser Issue], use clear and well formatted titles like "Error with parsing book [Book Name].[File Format]". +Duplicates and invalid issues will be closed. diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..04f63503 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,35 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: "\U0001F47E Bug" +assignees: Acclorite + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots (optional)** +If applicable, add screenshots to help explain your problem. + +**Device Info (please complete the following information):** + - Device: [e.g. Pixel 8] + - Android Version: [e.g. 14] + - Version of the app [e.g. v1.1.0] + +**Additional context (optional)** +Add any other context about the problem here. + +Please don't use titles like [Bug], use clear and well formatted titles like "Some error in Screen". +Duplicates and invalid issues will be closed. diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md new file mode 100644 index 00000000..4fe280d3 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -0,0 +1,23 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: "\U0001F680 Feature request" +assignees: Acclorite + +--- + +**Why you want this feature to be implemented? Please describe.** +Describe why you'd like to see this feature in the app. + +**Describe the feature you'd like to be implemented** +Describe as good as you can how you would like this feature to be implemented and idea behind it. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. + +Please don't use titles like [Feature Request], use clear and well formatted titles like "New feature in Screen". +Duplicates and invalid issues will be closed. From 50d892159c030aadf3fb9210d6c0ed3e3a4155f0 Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Mon, 12 Aug 2024 23:31:50 +0300 Subject: [PATCH 04/10] =?UTF-8?q?=F0=9F=9B=A0=EF=B8=8F=20Update=20issue=20?= =?UTF-8?q?templates?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Updated Book Parser Issue template description to be more clear. --- .github/ISSUE_TEMPLATE/book-parser-issue.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/book-parser-issue.md b/.github/ISSUE_TEMPLATE/book-parser-issue.md index 37082a73..fb8e8765 100644 --- a/.github/ISSUE_TEMPLATE/book-parser-issue.md +++ b/.github/ISSUE_TEMPLATE/book-parser-issue.md @@ -1,6 +1,6 @@ --- name: Book parser issue -about: Report an issue with parser +about: Report an issue with parser (problems with text parsing and adding books) title: '' labels: "\U0001F3BC Parser issue" assignees: Acclorite From d1a996c3296e3cd680c5df7bea0f3f7859d6f742 Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Thu, 15 Aug 2024 00:02:45 +0300 Subject: [PATCH 05/10] =?UTF-8?q?=E2=9C=92=EF=B8=8F=20Add=20translation=20?= =?UTF-8?q?progress=20in=20README.md?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Added translation progress in README. This can help more people to know that the project is available on Hosted Weblate. --- README.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index f066fbb7..38f91cdc 100644 --- a/README.md +++ b/README.md @@ -20,6 +20,7 @@ )](https://apt.izzysoft.de/fdroid/index/apk/ua.acclorite.book_story) [![Downloads](https://img.shields.io/github/downloads/Acclorite/book-story/total?color=3f8f9b&labelColor=27303D&label=Downloads&logo=GitHub)]() [![Stars](https://img.shields.io/github/stars/Acclorite/book-story?style=flat&logo=data%3Aimage%2Fsvg%2Bxml%3Bbase64%2CPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiPz4KPHN2ZyBoZWlnaHQ9IjI0IiB2aWV3Qm94PSIwIC05NjAgOTYwIDk2MCIgd2lkdGg9IjI0IiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgogIDxwYXRoIGQ9Im0zNTQtMjQ3IDEyNi03NiAxMjYgNzctMzMtMTQ0IDExMS05Ni0xNDYtMTMtNTgtMTM2LTU4IDEzNS0xNDYgMTMgMTExIDk3LTMzIDE0M1pNMjMzLTgwbDY1LTI4MUw4MC01NTBsMjg4LTI1IDExMi0yNjUgMTEyIDI2NSAyODggMjUtMjE4IDE4OSA2NSAyODEtMjQ3LTE0OUwyMzMtODBabTI0Ny0zNTBaIiBzdHlsZT0iZmlsbDogcmdiKDI0NSwgMjI3LCA2Nik7Ii8%2BCjwvc3ZnPg%3D%3D&color=949b3f&labelColor=27303D&label=Stars)](https://github.com/Acclorite/book-story/stargazers) + [![Translation Status](https://img.shields.io/weblate/progress/book-story?label=Translated&logo=weblate&labelColor=27303D&color=3f9b86)](https://hosted.weblate.org/engage/book-story/) [![Development Stage](https://img.shields.io/badge/Active-9b3f90?label=Development%20stage&labelColor=27303D)](https://github.com/Acclorite/book-story/commits/) [![Last Commit](https://img.shields.io/github/last-commit/Acclorite/book-story?label=Last%20commit&labelColor=27303D&color=749b3f)](https://github.com/Acclorite/book-story/commits/) [![License: GPL-3.0](https://img.shields.io/github/license/Acclorite/book-story?label=License&labelColor=27303D&color=3f9b75)](/LICENSE) @@ -111,8 +112,11 @@ _Don't see your favorite app store? Create an [Issue](https://github.com/Acclori ## 🌐 Translation -- English (Default) -- Ukrainian (Default) + +[Translation progress](https://hosted.weblate.org/engage/book-story/) +
+ +_You can help translating the app on [Hosted Weblate](https://hosted.weblate.org/engage/book-story/)._ @@ -121,9 +125,9 @@ _Don't see your favorite app store? Create an [Issue](https://github.com/Acclori - **Place your suggestions on Issues with [Suggestion Needed](https://github.com/Acclorite/book-story/labels/%F0%9F%93%9D%20Suggestion%20needed) label.** When the issue has this label that means I seek new ideas on how to improve what I already propose. Feel free to tell me what's on your mind! - **Share your ideas and suggestions.** Your ideas and suggestions are always welcome, if you miss some feature or got an interesting idea, feel free to create a new [Issue](https://github.com/Acclorite/book-story/issues). - **Report bugs**. Had a crash or something went wrong? Create a new [Issue](https://github.com/Acclorite/book-story/issues), the more information you can give the better it is. + - **Translate the app**. You can do what I physically cannot - translate the app on multiple languages. For this you can use [Hosted Weblate](https://hosted.weblate.org/engage/book-story/). - **Enjoy the app**. Your best contribution is using my app and enjoying it! - - _**About localization**. Planning to implement localiztion platform, so users can do what I physically cannot - translate the app on multiple languages. You can find more information about this in the corresponding issue([#22](https://github.com/Acclorite/book-story/issues/22))._ - + ## 🤗 Credits From 4eba0474415e5809debbd74404dc0e07faf315a3 Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Thu, 15 Aug 2024 14:11:08 +0300 Subject: [PATCH 06/10] =?UTF-8?q?=F0=9F=8C=8D=20Make=20"app=5Fname"=20untr?= =?UTF-8?q?anslatable?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Made app's name untranslatable as it's translation may differ in different languages, losing it's point. --- app/src/main/res/values-uk/strings.xml | 3 --- app/src/main/res/values/strings.xml | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/app/src/main/res/values-uk/strings.xml b/app/src/main/res/values-uk/strings.xml index 497e2f34..a0b37176 100644 --- a/app/src/main/res/values-uk/strings.xml +++ b/app/src/main/res/values-uk/strings.xml @@ -1,7 +1,4 @@ - - Історія Книги - Архів Анни|https://uk.annas-archive.org diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 86cbf832..307c99ef 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -1,7 +1,7 @@ 1.1.1 - Book\'s Story + Book\'s Story From 5ed30fc73fc847129e6d5993578888cc67aa17c5 Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Thu, 15 Aug 2024 14:21:59 +0300 Subject: [PATCH 07/10] =?UTF-8?q?=F0=9F=8C=8D=20Translate=20app's=20name?= =?UTF-8?q?=20as=20"Book's=20Story"=20everywhere?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Translated app's name as Book's Story in all locales. --- app/src/main/res/values-uk/strings.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/res/values-uk/strings.xml b/app/src/main/res/values-uk/strings.xml index a0b37176..c57e536a 100644 --- a/app/src/main/res/values-uk/strings.xml +++ b/app/src/main/res/values-uk/strings.xml @@ -7,7 +7,7 @@ Нові оновлення - Нове оновлення Історії Книги! + Нове оновлення Book\'s Story! Оновлення %1$s вийшло! Натисніть, щоб перейти на сторінку релізу. @@ -70,7 +70,7 @@ Будь ласка, запам\'ятайте де ви зупинилися перед оновленням тексту. - Нова версія Історії Книги була знайдена. + Нова версія Book\'s Story була знайдена. Чи бажаєте завантажити її? Натиснувши на кнопку «Завантажити», ви перейдете в ваш браузер та завантажете останнє оновлення автоматично. @@ -475,7 +475,7 @@ - Вітаємо в Історія Книги! + Вітаємо в Book\'s Story! У світ, де слова чарують, вчать та ведуть у неймовірні пригоди! Давайте дещо налаштуємо! From 40890d816570c7b379b2cd3d18192b1f3a9ceacb Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Thu, 15 Aug 2024 14:54:16 +0300 Subject: [PATCH 08/10] =?UTF-8?q?=F0=9F=8C=8D=20Remove=20unused=20string?= =?UTF-8?q?=20(credits=5Fmotivation)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removed unused string resource. --- app/src/main/res/values-uk/strings.xml | 1 - app/src/main/res/values/strings.xml | 1 - 2 files changed, 2 deletions(-) diff --git a/app/src/main/res/values-uk/strings.xml b/app/src/main/res/values-uk/strings.xml index c57e536a..217d379c 100644 --- a/app/src/main/res/values-uk/strings.xml +++ b/app/src/main/res/values-uk/strings.xml @@ -313,7 +313,6 @@ Дизайн Іконки Керування новими оновленнями - Мотивація Будь ласка, зверніть увагу, що на diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 307c99ef..d7c8542e 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -332,7 +332,6 @@ Design Icons New updates managing - Motivation Please note, that From 84bae8c033098f65299ff087f2b2173daffb27a4 Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Thu, 15 Aug 2024 14:56:50 +0300 Subject: [PATCH 09/10] =?UTF-8?q?=F0=9F=8C=8D=20Remove=20translation=20of?= =?UTF-8?q?=20title=20from=20fastlane?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removed translation of title from fastlane. --- fastlane/metadata/android/uk/title.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 fastlane/metadata/android/uk/title.txt diff --git a/fastlane/metadata/android/uk/title.txt b/fastlane/metadata/android/uk/title.txt deleted file mode 100644 index 38ea5488..00000000 --- a/fastlane/metadata/android/uk/title.txt +++ /dev/null @@ -1 +0,0 @@ -Історія Книги \ No newline at end of file From 6797bf03fb7c2cbc32cb75a43f48a4b808a418c9 Mon Sep 17 00:00:00 2001 From: Acclorite <140836141+Acclorite@users.noreply.github.com> Date: Thu, 15 Aug 2024 18:36:16 +0300 Subject: [PATCH 10/10] =?UTF-8?q?=F0=9F=9B=A0=EF=B8=8F=20Fix=20Slider=20sk?= =?UTF-8?q?ips=20one=20step?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixed SliderWithTitle skips one step. --- .../presentation/screens/settings/components/SliderWithTitle.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/ua/acclorite/book_story/presentation/screens/settings/components/SliderWithTitle.kt b/app/src/main/java/ua/acclorite/book_story/presentation/screens/settings/components/SliderWithTitle.kt index 69246694..7643ce53 100644 --- a/app/src/main/java/ua/acclorite/book_story/presentation/screens/settings/components/SliderWithTitle.kt +++ b/app/src/main/java/ua/acclorite/book_story/presentation/screens/settings/components/SliderWithTitle.kt @@ -72,7 +72,7 @@ fun SliderWithTitle( onValueChange = { onValueChange(it.roundToInt()) }, - steps = toValue - fromValue, + steps = toValue - fromValue - 1, colors = SliderDefaults.colors( activeTickColor = MaterialTheme.colorScheme.onPrimary, inactiveTickColor = MaterialTheme.colorScheme.onSurfaceVariant,